Child pages
  • [in-commerce] 3rd refactoring of Shipping Quote Engines related to USPS
Skip to end of metadata
Go to start of metadata

Imported from: http://groups.google.com/group/in-portal-dev/browse_thread/thread/74b6305480f985db#

We have method, named "MakeUSPSOrder" in OrderEventHandler class. This not good, since we have separate class for USPS interaction code.

I propose to create universal method MakeOrder in each SQE (ShippingQuoteEngine) and move MakeUSPSOrder to one of them. This way we will determine SQE by shipping type used in order and delegate all specific processing to it.

usps_to_sqe_incommerce.patch

Related Tasks

MINC-64 - Getting issue details... STATUS

6 Comments

  1. Hi Alex,

    I have ran some tests on 5.1.x (5.1.1-B1).

    like we need some work.

    For some reason we never got to "MakeOrder" with USPS. See part of the DEBUG
    occurred during Ship Order action.

    Let me know if you want access to my test site.

    DA.

  2. Have you tried order approving? Did it called MakeOrder then?
    On Sep 23, 2010 9:21 PM, "Dmitry Andrejev" <dandre...@gmail.com> wrote:

  3. No, it haven't called the method... at least it didn't get inside of it.

    Let me know what's next. I can actually give you the account info and you
    can try run this from your development.

    DA.

  4. Agreed, give it to me (maybe in private email).

  5. New patch attached (in task too).

  6. It was tested good and was included in 5.1.1 Beta1

    DA.