Child pages
  • Incorrectly named labels used in System Settings [5.2.1-B1]
Skip to end of metadata
Go to start of metadata

In INP-1077 - Getting issue details... STATUS  task we've added a page to ease up new setting adding. We've also introduced some basic format validations there, for example:

  • system setting label must start with "la_config_"
  • system setting heading label must start with "la_section_"

However it seems, that most part of existing system settings doesn't obey these rules, which results in inability to add/edit system setting configuration (not values). Here are statistics:

Heading LabelSetting Count
no label11
la_config_DefaultIncreaseImportance5
la_config_DefaultPop5
la_config_DefaultRating5
la_config_SearchRel_DefaultKeyword5
la_config_ShowMultiple4
la_posts_subheading1
la_Text_Affiliates3
la_Text_Articles17
la_Text_ContactsGeneral7
la_Text_Coupons1
la_Text_Currencies1
la_Text_Date_Time_Settings2
la_Text_Links21
la_Text_Manufacturers2
la_Text_MetaInfo2
la_Text_Orders11
la_Text_Polls2
Total105

This is 105 incorrect of 386 total, which is 27% of all system settings have incorrect labels.

Looking at Prompt field, that contains a label for system setting name itself numbers are higher: 238 out of 386 doesn't start with "la_config_", which is 61%.


I think we need to take care of that as sooner as possible, because adding this extra validation for system settings, while not fixing existing system settings we've shot self in a leg (sad)